Conversation
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| static void extractTestData() throws IOException { | ||
| if (!Files.exists(ZIP_FILE)) { | ||
| throw new RuntimeException("Test data ZIP file not found: " + ZIP_FILE.toAbsolutePath()); | ||
| } | ||
|
|
||
| // Create target directory | ||
| Files.createDirectories(TARGET_SUITE_DIR.getParent()); | ||
|
|
||
| // Extract ZIP file | ||
| try (ZipInputStream zis = new ZipInputStream(new FileInputStream(ZIP_FILE.toFile()))) { | ||
| ZipEntry entry; | ||
| while ((entry = zis.getNextEntry()) != null) { | ||
| if (!entry.isDirectory() && (entry.getName().startsWith("draft2020-12/") || entry.getName().startsWith("remotes/"))) { | ||
| Path outputPath = TARGET_SUITE_DIR.resolve(entry.getName()); | ||
| Files.createDirectories(outputPath.getParent()); |
There was a problem hiding this comment.
[P1] Fix ZIP extraction to match prefixed entries
The new extractTestData skips every entry in json-schema-test-suite-data.zip because it only processes names starting with draft2020-12/ or remotes/. The bundled ZIP actually stores files under json-schema-test-suite/draft2020-12/... (see unzip -l), so none of the entries ever match the filter. As a result, no files are extracted and the final existence check throws RuntimeException("Extraction completed but target directory not found…"), breaking JsonSchemaCheckIT. Adjust the prefix detection (e.g., strip the leading folder) so the suite is unpacked before running tests.
Useful? React with 👍 / 👎.
1 participant
No description provided.