Conversation
- Created json-java21-jtd submodule with comprehensive test infrastructure - Added JtdSpecIT.java running official JTD Test Suite (365 tests total) - Implemented both validation.json (316 tests) and invalid_schemas.json (49 tests) - Added DocumentationAJvTests.java with AJV documentation examples - Created ARCHITECTURE.md with detailed JTD design and RFC 8927 compliance plan - Set up proper JUL logging following json-java21-schema patterns - Added comprehensive /// javadoc documentation for test formats - Configured Maven dependencies and build integration - All tests currently passing with placeholder validation - Ready for actual JTD validator implementation Test execution: $(command -v mvnd || command -v mvn || command -v ./mvnw) test -pl json-java21-jtd -Dtest=JtdSpecIT 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Simplified the JTD implementation to follow RFC 8927 exactly: **Removed:** - Strict/lenient mode complexity (-Djtd.strict system property) - SKIPPED_TESTS set and conditional test skipping - Complex metrics with skipped test counting - Lenient mode logging and failure handling **Simplified:** - Single test execution path - all tests must pass - Clean metrics: total/passed/failed only - Direct test failure reporting without mode conditions - Architecture docs updated to remove strict/lenient references **What remains:** - Official JTD Test Suite (365 tests): validation.json + invalid_schemas.json - RFC-compliant error format: instancePath + schemaPath - Single command: $(command -v mvnd || command -v mvn || command -v ./mvnw) test -pl json-java21-jtd -Dtest=JtdSpecIT - Comprehensive /// javadoc documentation This follows the RFC specification without additional complexity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
… tests passing - Created JtdSchema sealed interface with eight RFC 8927 schema forms - Implemented JtdValidator with proper JUL logging at INFO/FINE levels - Updated JtdSpecIT to use actual validation instead of placeholder - Added ValidationResult and ValidationError classes following DOP patterns - 345 out of 365 JTD spec tests now pass (95% success rate) - Tests show proper INFO level execution logging per AGENTS.md requirements The implementation covers all eight JTD forms: - Empty, Ref, Type, Enum, Elements, Properties, Values, Discriminator - Proper nullable support and mutually-exclusive form validation - Simple validation logic following JSON Schema patterns but much simpler To test: /opt/homebrew/bin/mvnd -pl json-java21-jtd test -Djava.util.logging.ConsoleHandler.level=INFO
… documentation - Removed all references to deleted json-java21-schema module from AGENTS.md - Updated top-level README.md to mention JTD validator instead of JSON Schema validator - Created comprehensive README.md in json-java21-jtd/ with user documentation - Updated ARCHITECTURE.md to remove json-java21-schema references - All JTD RFC 8927 compliance tests are passing
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Updated expected test counts from 4436 tests/1692 skipped to 460 tests/0 skipped after removing the json-java21-schema module and adding json-java21-jtd module.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
simbo1905
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR #87 deletes the json-java21-schema module and adds a complete implementation of JSON Type Definition (JTD) RFC 8927 validator as requested in issue #85. Here's what was accomplished:
🎯 What Was Actually Built (Issue #85)
📊 Scope of Work
🏗️ Key Implementation Files
✅ All CI Checks Passing