Add support for transactions with payees#14
Open
pmarciniak wants to merge 6 commits intosimon-v:masterfrom
Open
Add support for transactions with payees#14pmarciniak wants to merge 6 commits intosimon-v:masterfrom
pmarciniak wants to merge 6 commits intosimon-v:masterfrom
Conversation
…ption when parsing the ledger.
Owner
|
Why do you consider "descriptions" like |
Contributor
Author
|
Yeah, I guess you can use them to enter new transactions, but when you want to search for a transaction with a given description/payee, it becomes a bit more messy. Also, some payees may have multiple descriptions associated with them, and vice versa (e.g. transactions with "Groceries" description may exist for multiple payees), which makes the auto-completion feature work in a suboptimal way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option 'y'. If it's set, transaction entering flow will ask for a payee in addition to description. Entering payees has the same support for defaults and completion as entering descriptions.
Since either payee or description may now legitimately be empty, I've added a special value "-" to not accept the proposed default and enter an empty string instead.
Even with the 'y' option disabled, parsing of transactions is now aware of payees, so it no longer parses broken descriptions like
Central Perk" "Scone.