chore(deps): update dependency msw to v2.12.4

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
msw (source)	2.12.3 -> 2.12.4

---

Release Notes

mswjs/msw (msw)

v2.12.4

Compare Source

v2.12.4 (2025-12-03)

Bug Fixes

• handle incomplete localStorage in Node.js v25 (#​2636) (3da2c76) @​rvagg

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[railway-app]

🚅 Environment simon.dev-pr-1399 in simon.dev has no services deployed.

[claude]

Claude finished @renovate[bot]'s task —— View job

---

Code Review: MSW v2.12.4 Update

Summary

This is a minor patch update for MSW (Mock Service Worker) from v2.12.3 to v2.12.4. The update addresses a bug fix for incomplete localStorage in Node.js v25.

Review Findings

✅ Code Quality: APPROVED

Changes:

• package.json: Version bump from 2.12.3 → 2.12.4
• pnpm-lock.yaml: Updated dependency resolution and checksums

Assessment:

• Clean dependency-only update with no code changes
• All changes are automated by Renovate bot
• Follows semver correctly (patch version for bug fix)

✅ Security: APPROVED

Assessment:

• This is a patch release from a trusted source (mswjs)
• No known security vulnerabilities introduced
• Bug fix improves compatibility with Node.js v25
• No changes to API surface or behavior

Bug Fix Details:
The update addresses #2636 - handling incomplete localStorage in Node.js v25. This is a forward-compatibility fix that won't affect the current setup (Node.js 24.11.1) but ensures compatibility with future Node versions.

✅ Performance: APPROVED

Assessment:

• No performance implications
• Pure bug fix release with no architectural changes
• MSW is a dev dependency used only in tests

✅ Testing: APPROVED

Test Coverage:
I verified that MSW is properly integrated in the test suite:

• MSW server configured in mocks/node.ts
• Lifecycle hooks in vitest.setup.ts (beforeAll, afterEach, afterAll)
• Extensively used in tests (especially app/lib/lastfm.test.ts and app/lib/discord/api.test.ts)
• Uses modern MSW v2 API (http.get, HttpResponse)

CI Status:

• ✅ CI workflow passed successfully
• ✅ PR checks passed
• Test failures I encountered locally were due to Node version mismatch (running on Node 20 vs required Node 24), not MSW-related issues

Test Patterns Verified:

// Example from app/lib/lastfm.test.ts
server.use(
  http.get(LASTFM_BASE_URL, ({ request }) => {
    // Request validation
    return HttpResponse.json({ /* mock data */ });
  })
);

All test patterns are compatible with MSW v2.12.4.

✅ Documentation: N/A

No documentation changes needed for a patch dependency update.

---

Recommendation: ✅ APPROVE AND MERGE

Rationale:

1. Safe update: Patch version with single bug fix for Node.js v25 compatibility
2. CI passing: All automated checks passed successfully
3. No breaking changes: MSW v2 API remains stable
4. Forward compatibility: Prepares codebase for future Node.js upgrades
5. Low risk: Dev dependency only, no production impact

Additional Notes:

• Automerge is enabled for this PR, which is appropriate for this type of update
• The project's test suite has excellent MSW integration and will catch any issues
• Consider approving to let automerge complete the update automatically

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.98%. Comparing base (98c3746) to head (2af01f0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files          44       44           
  Lines         653      653           
  Branches      108      108           
=======================================
  Hits          568      568           
  Misses         71       71           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.