Skip to content

Comments

chore(deps): update dependency eslint to v10#1611

Merged
simonkberg merged 2 commits intomainfrom
claude/apply-nextjs-89764-fix-8hoOe
Feb 21, 2026
Merged

chore(deps): update dependency eslint to v10#1611
simonkberg merged 2 commits intomainfrom
claude/apply-nextjs-89764-fix-8hoOe

Conversation

@simonkberg
Copy link
Owner

No description provided.

renovate bot and others added 2 commits February 21, 2026 06:15
Set explicit React version in ESLint settings to work around
eslint-plugin-react calling the removed context.getFilename() API
during version auto-detection.

Ref: vercel/next.js#89764 (comment)

https://claude.ai/code/session_01QgBooxzPxfhof4UKSLXb4L
@railway-app railway-app bot temporarily deployed to simon.dev / simon.dev-pr-1611 February 21, 2026 06:44 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 21, 2026

🚅 Deployed to the simon.dev-pr-1611 environment in simon.dev

Service Status Web Updated (UTC)
simon.dev ✅ Success (View Logs) Web Feb 21, 2026 at 6:46 am

@claude
Copy link
Contributor

claude bot commented Feb 21, 2026

Claude finished @simonkberg's task in 1m 21s —— View job


Code Review

  • Gather context and read changed files
  • Review eslint.config.ts changes
  • Review package.json changes
  • Analyze pnpm-lock.yaml changes
  • Provide comprehensive review feedback

Summary

This PR upgrades ESLint from v9.39.3 to v10.0.1, accompanied by a follow-up fix commit (abb2d90) that works around a compatibility issue with eslint-plugin-react in ESLint v10.

Overall: LGTM with one minor observation.


eslint.config.ts — Fix Commit (abb2d90)

+ { settings: { react: { version: "19" } } },

Correct approach. ESLint v10 removed the deprecated context.getFilename() API. eslint-plugin-react's React version auto-detection relies on this API, causing a crash during linting. Setting an explicit version: "19" bypasses the auto-detection entirely.

This is the correct workaround as documented in the Next.js issue #89764. Once eslint-plugin-react releases a fix for the removed API, this setting can remain in place (it's a valid explicit config anyway).


package.json — Dependency Bump

- "eslint": "9.39.3",
+ "eslint": "10.0.1",

Clean, straightforward version bump. No issues here.


pnpm-lock.yaml — Notable Changes

The lock file updates are consistent with the version bump. A few notable observations:

Node.js engine requirement tightened:
ESLint v10's internal packages (e.g., @eslint/config-array, @eslint/core, @eslint/plugin-kit) now require ^20.19.0 || ^22.13.0 || >=24 instead of ^18.18.0 || ^20.9.0 || >=21.1.0. This is more restrictive but aligns with the project's Node.js 24 requirement in package.json — no issue here.

Removed legacy package @eslint/eslintrc:
ESLint v10 drops the legacy eslintrc-style config compatibility shim entirely. Since this project uses the flat config format (eslint.config.ts), this is expected and correct.

Removed @eslint/js:
ESLint v10 has reorganized its internal structure; @eslint/js is no longer listed as a separate dependency in the lock file (it's now bundled). This is an internal ESLint change with no impact on usage.

New: eslint-visitor-keys@5.0.1 and @types/esrecurse@4.3.1:
These are new transitive additions from ESLint v10. Both are expected and benign.

acorn updated from 8.15.0 → 8.16.0: Minor patch bump, expected.


No Issues Found

  • No security concerns
  • No missing tests (this is a pure dependency upgrade)
  • The eslint-plugin-react crash workaround is correct and well-documented in the commit message with a reference link
  • All peer dependency resolutions in the lock file look correct (eslint-config-next, eslint-config-prettier, eslint-plugin-simple-import-sort all resolve against ESLint 10)

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (99d57d2) to head (abb2d90).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          49       49           
  Lines         916      916           
  Branches      161      161           
=======================================
  Hits          896      896           
  Misses          8        8           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simonkberg simonkberg merged commit 9a2f348 into main Feb 21, 2026
8 checks passed
@simonkberg simonkberg deleted the claude/apply-nextjs-89764-fix-8hoOe branch February 21, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants