print: allow decimal point aligning, like ledger-mode (WIP)#1052
Draft
simonmichael wants to merge 1 commit intomasterfrom
Draft
print: allow decimal point aligning, like ledger-mode (WIP)#1052simonmichael wants to merge 1 commit intomasterfrom
simonmichael wants to merge 1 commit intomasterfrom
Conversation
And use it. Plus some comments on decimal point aligning.
Collaborator
|
I've tampered with this a couple times but my Haskell isn't really up to delivering anything useful. On the other hand I do wish for it to be done quite frequently. My current reliance on the vim plugin to normalize my journal files is somewhat brittle and, while it gets closer to this output than |
56bc295 to
01f9c70
Compare
Owner
Author
|
I accidentally closed this by cleaning up old branches. I have restored the https://github.com/simonmichael/hledger/tree/1045-print branch, but the PR can't be reopened it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1045. I created showTransaction2 and helpers, with the immediate goal of (a) clarifying this code and (b) implementing output like ledger-mode's :decimal setting.
What I had in mind: for postingAsLines to do decimal mark alignment, it needs to know which part of each rendered amount is to left and which to the right of the decimal mark. The decimal mark can be period or comma, and that character can also appear in a (double quoted) commodity symbol, so parsing the rendered amount seems a bit fiddly with potential to get out of sync with rendering code. I thought instead to have helpers like showMixedAmountLR & showMixedAmountOneLineLR which return the left and right parts; possibly showMixedAmount[OneLine] would use these also. These would need a showAmountLR :: Amount -> (String,String).