run less more robustly; don't add --quit-at-eof#2546
Merged
simonmichael merged 3 commits intomasterfrom Feb 1, 2026
Merged
Conversation
Owner
Author
|
This is in today's https://github.com/simonmichael/hledger/releases/tag/testlatest binaries, all testing including on old environments is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more robust handling of various less and pager failure mode. Generally when anything goes wrong, it should always fall back to printing the output unpaged.
Based on feedback from chat, I have removed --quit-at-eof from the options that hledger adds to LESS when using less as pager. It meant that when you scrolled to the bottom of long output, you would often end up exiting less by accident, so you couldn't scroll back up. Now when less is invoked (because output is longer than the window), you'll always see its end of output indicator at the bottom and you'll always have to press q to exit.
Of course you can override this default by setting your preferred less options in HLEDGER_LESS (or by setting PAGER to something else or by using --pager=no).
Related: #2544