Skip to content

Support multiple code unit charaters #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
realityking wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Support multiple code unit charaters #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slugify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

var replacement = options.replacement === undefined ? '-' : options.replacement

var slug = string.normalize().split('')
var slug = Array.from(string.normalize())
// replace characters based on charMap
.reduce(function (result, ch) {
return result + (locale[ch] || charMap[ch] || ch)
Expand Down
10 changes: 10 additions & 0 deletions test/slugify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,16 @@ describe('slugify', () => {
t.equal(slugify('unicode ♥ is ☢'), 'unicode-love-is')
})

it('replace characters made up of multiple code units', () => {
slugify.extend({'🚣': 'person-rowing-boat'})
t.equal(slugify('she is a 🚣'), 'she-is-a-person-rowing-boat')

delete require.cache[require.resolve('../')]
slugify = require('../')

t.equal(slugify('she is a 🚣'), 'she-is-a')
})

it('normalize', () => {
var slug = decodeURIComponent('a%CC%8Aa%CC%88o%CC%88-123') // åäö-123
t.equal(slugify(slug, {remove: /[*+~.()'"!:@]/g}), 'aao-123')
Expand Down