Conversation
The change is compatible with numpy<2
BradleyMak
left a comment
There was a problem hiding this comment.
Thanks for working on this @Mateasek! The changes you've made look good, but the issue described actually upgrading the version of numpy used to >=2.0.0, so the poetry configuration (in pyproject.toml and poetry.lock) should also be updated in this MR to reflect that, ensuring that any related dependencies are also upgraded if required. Once this has been added, I'll do some more testing.
|
Hi @BradleyMak , The changes I applied should make it compatible with |
|
Hi @Mateasek, Running |
|
Thanks for the guidance. As requested, I set the |
Description of work
Adds compatibility with
numpy>2while keeping compatibility withnumpy<2Fixes
Implements #87 #86: It seems it was enough to replace
np.fromstringwithnp.frombuffer, tested fornumpy < 2andnumpy > 2.Pytests were also updated (np.bool -> np.bool_) to be compatible with
numpy < 2andnumpy > 2To test
I could not pass server tests, but I don't think that is relevant to this PR,
dataclasstests pass. I also tested by remotely getting data from JET ppfs. It worked and the data made sense.Reviewer checklist