-
Notifications
You must be signed in to change notification settings - Fork 21
Maria Herrera - Bootcamp Activities #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
16adba2
05ad60a
3716fc3
87a0795
ccc20ea
5a2266a
19eebf7
d2ad879
6a88101
aa4e077
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,117 @@ | |
| <body> | ||
|
|
||
| <!-- Add your code here --> | ||
|
|
||
| <div class="slider"> | ||
| <!-- Slide 1 --> | ||
| <div class="slide" style="background-image: url('image1.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 1</h2> | ||
| <p>Description for Slide 1</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 2 --> | ||
| <div class="slide" style="background-image: url('image2.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 2</h2> | ||
| <p>Description for Slide 2</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 3 --> | ||
| <div class="slide" style="background-image: url('image3.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 3</h2> | ||
| <p>Description for Slide 3</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 4 --> | ||
| <div class="slide" style="background-image: url('image4.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 4</h2> | ||
| <p>Description for Slide 4</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 5 --> | ||
| <div class="slide" style="background-image: url('image5.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 5</h2> | ||
| <p>Description for Slide 5</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 6 --> | ||
| <div class="slide" style="background-image: url('image6.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 6</h2> | ||
| <p>Description for Slide 6</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 7 --> | ||
| <div class="slide" style="background-image: url('image7.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 7</h2> | ||
| <p>Description for Slide 7</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 8 --> | ||
| <div class="slide" style="background-image: url('image8.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 8</h2> | ||
| <p>Description for Slide 8</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 9 --> | ||
| <div class="slide" style="background-image: url('image9.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 9</h2> | ||
| <p>Description for Slide 9</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 10 --> | ||
| <div class="slide" style="background-image: url('image10.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 10</h2> | ||
| <p>Description for Slide 10</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 11 --> | ||
| <div class="slide" style="background-image: url('https://placehold.co/1024x720');"> | ||
| <div class="slide-content"> | ||
| <h1><strong>Phase 4:</strong></h1> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For a usual site structure, we wouldn't or shouldn't be using an h1 here as it disrupts the logical order of the page. H1s should be for the primary heading of the page. Here, the h1 heading is following the h2 headings of the previous slides.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for clearing up the h1 usage, I was a bit unsure about it too! |
||
| <h2>Destination Thrive</h2> | ||
| <h3>Objective: Create omni-channel synergy</h3> | ||
| <p>This is the time to fully leverage your hard work and thrive. During this<br> | ||
| phase, attention should be given to creating omni-channel synergy,<br> | ||
| syncing your messaging and channels from top to bottom.</p> | ||
| <hr> | ||
| <h4><strong>Key Focus:</strong></h4> | ||
| <ul> | ||
| <li>Harvesting the demand created by your content marketing efforts</li> | ||
| <li>Scale paid media and social efforts</li> | ||
| <li>Leverage your new audiences</li> | ||
| <li>Omin-channel synergy</li> | ||
| </ul> | ||
|
|
||
| <h4><strong>Time</strong> <span class="clock-icon"></span></h4> | ||
| <p>aprox. 24 months and beyond</p> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Slide 12 --> | ||
| <div class="slide" style="background-image: url('image12.jpg');"> | ||
| <div class="slide-content"> | ||
| <h2>Slide 12</h2> | ||
| <p>Description for Slide 12</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </body> | ||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
|
|
||
| <style> | ||
| /* Update the following line of CSS to only style `<p>` that follow an `<h2>` */ | ||
| p { | ||
| h2 ~ p { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One could argue that the instructions isn't fully clear though, depending on how you interpret that sentence, but this is the general sibling selector. My counter argument here would be that, if you look at your file here, all of the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All good, thanks! |
||
| font-size: 22px; | ||
| line-height: 1.5; | ||
| color: rebeccapurple; | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a note than a correction, when structuring content for a widget, we wouldn't typically lay out the content to bold text via
<strong>elements, and handle that via CSS instead.That said, your use of them isn't incorrect here. It was just worth noting since, when building a widget on one of our sites, the code reviewer may send it back to have you bold the text via CSS rather than using the
<strong>element.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I appreciate the clarification.