Skip to content

Conversation

@wk9874
Copy link
Collaborator

@wk9874 wk9874 commented Oct 13, 2025

Fix GridMetrics serializer typing

Python Version(s) Tested: 3.10

Operating System(s): Ubuntu 22.04

📝 Summary

serialize_array in GridMetricSet has the wrong typing - doesnt include list[list[float]] as an option in the inputs and return type

🔍 Diagnosis

Lots of these warnings printed:

  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value=[20.0, 20.0, 20.0, 20.0, ... 20.0, 20.0, 20.0, 20.0], input_type=list])

🔄 Changes

Add correct typing

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@wk9874 wk9874 requested a review from kzscisoft October 13, 2025 16:16
@kzscisoft kzscisoft merged commit d94fd64 into dev Oct 14, 2025
20 checks passed
@kzscisoft kzscisoft deleted the wk9874/fix_grid_typing branch October 14, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants