🐛 Ensure only valid arguments are sent to the server #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzscisoft
added
bug
kzscisoft
force-pushed
the
hotfix/fix-extra-args-in-restapi-calls
branch
from
dda91e2 to
68223a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Invalid Arguments being sent to Server
Issue: N/A
Python Version(s) Tested: 3.14
Operating System(s): Ubuntu 24.05
📝 Summary
The server now forbids unrecognised arguments in requests, the Python API until this point was sending such arguments.
🔍 Diagnosis
Error 422 now sent by server. Due to the way the LLAPI works arguments are provided at a single level whereas the server uses nested arguments for, e.g. alerts. Until now all arguments were sent to the server and the extra ignored but now the server will throw an error.
🔄 Changes
Patched by adding an internal attribute to
SimvueObjectwhich lists which keys/attributes present in the staging for the class instance should not be sent to the server.✔️ Checklist