Skip to content

Conversation

@matsk-sinch
Copy link
Contributor

No description provided.

Copy link
Contributor

@asein-sinch asein-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You validate exactly what is needed for snippets, and using a custom "short-circuit" exception by patching the transport layer is clever 👍
Very good job indeed 👏

Comment on lines +1 to +3
"""
Validate that snippets have valid syntax, working imports, and correct SDK method names.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
Validate that snippets have valid syntax, working imports, and correct SDK method names.
"""
"""
Validate that snippets have valid syntax, working imports, and reference existing SDK methods by executing them until the first outbound API call.
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants