Fix CodeQL uncontrolled-allocation-size false positive#72
Merged
zourzouvillys merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
CodeQL doesn't recognize Go's min() builtin as a taint sanitizer, so the uncontrolled-allocation-size alert persisted despite correct bounds. Route through a clampInt helper that returns a fresh variable, severing the taint propagation from user input to make().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go/uncontrolled-allocation-sizealert onreplication_events.go:70persisted despite correctmin()bounds because CodeQL doesn't recognize Go'smin()builtin as a taint sanitizerclampInt()helper with explicit if-comparisons, returning a fresh variable (count) that severs the taint chain from user input tomake()Fixes https://github.com/sixfathoms/lplex/security/code-scanning/7
Test plan
TestEventLog*tests pass