Support the case when a value is missing the ending quote#17
Merged
skalahonza merged 3 commits intoskalahonza:masterfrom Jun 18, 2025
Merged
Support the case when a value is missing the ending quote#17skalahonza merged 3 commits intoskalahonza:masterfrom
skalahonza merged 3 commits intoskalahonza:masterfrom
Conversation
Microsoft INF parsing assumes a newline ends the quoted value
skalahonza
approved these changes
Jun 18, 2025
Owner
skalahonza
left a comment
skalahonza
left a comment
There was a problem hiding this comment.
Thank you for your contribution — it's much appreciated!
Just out of curiosity (and no need for credits or anything like that), what kind of product are you developing that uses this library?
I also noticed your email ends with intel.com. Are you using this library as part of an Intel-related solution? If so, that would be a really cool reference for this little package 😄
If the product is public, I’d love to check it out — feel free to share a link if you’re comfortable!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft INF parsing assumes a newline ends the quoted value
Goal
Closes #16
Background
Microsoft INF parsing and INF validator allows for a value with a starting quote and no ending quote, assuming a newline as the end of the value. Valid Windows INFs are not able to be parsed by this library without this change.
Implementation
Added new line as a supported character to pure value parsing
Testing
Added unit test and verified existing tests pass