Closed
Conversation
Remove nuget/build scripts and executables Enable nullable Fix nullability warnings Change to file scoped namespaces
Owner
|
Thank you for this contribution. I will try to give you a review this week. |
Author
|
Thanks. Apologies, but I did not mean for that second commit on this branch, that was intended for #21 Additionally, best guess as to the builds failing is the CI/CD being configured to use net6 which went end of support in Nov 2024. This PR was written w/ language features and compiled for net8 and net10 |
Author
|
Sure thing, I should be able to tackle that some time today. |
skalahonza
reviewed
Nov 21, 2025
Owner
skalahonza
left a comment
skalahonza
left a comment
There was a problem hiding this comment.
i am only confused by this commented file
Owner
There was a problem hiding this comment.
what is this commented file for?
Author
|
I'm going to close this for now, I'm working on a different approach that should make this PR obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to .net 8. Note that end of support for 8 is approx 1 year away, but the code functions as is in .net 10 as well.
Move to a more traditional folder structure.
Remove nuget/build scripts and executables.
Enable
nullable.Fix nullability warnings.
Change to file scoped namespaces.
Goal
Eliminate potential
NullReferenceExceptionexceptions.Background
Widespread use of null is ripe for NRE issues, enabling
nullableand adding proper null check safeguards prevents this.Implementation
Enabled
nullablein projects, and fixed compiler generated warnings with null checks.Testing
Ran unit tests. One test does fail (
CustomSerializationTest2) however I think that test should fail, as it is attempting to parse a property that does not exist in the INF file. Previously it would return null, however withnullableenabled that was generating a compiler warning.