Draft
Conversation
nover
changed the title
nover
force-pushed
the
57-find-a-way-to-consistently-test-the-git-vcs-provider
branch
2 times, most recently
from
5d447c6 to
ce9c90c
Compare
nover
force-pushed
the
57-find-a-way-to-consistently-test-the-git-vcs-provider
branch
from
ce9c90c to
0dda984
Compare
Contributor
Author
|
The commit tests are working locally, they are probably failing in CI due to missing author info |
nover
force-pushed
the
57-find-a-way-to-consistently-test-the-git-vcs-provider
branch
2 times, most recently
from
071d805 to
4fc6c6b
Compare
pingvinen
requested changes
May 25, 2021
| } | ||
|
|
||
| [Fact] | ||
| public void DetectingGitOnMachineWorks() |
Contributor
There was a problem hiding this comment.
question: can we make a negative test for this as well?
I am not sure how to go about it, but currently the implementation could just be return true and the test would pass :)
Contributor
Author
There was a problem hiding this comment.
I guess we could but I'm not sure how easily that is done - I do agree with your comment though.
running it on a machine without git in CI will not work, as it won't be able to get the source code - but perhaps altering the path for the process info we use to launch the tool will work.
| } | ||
|
|
||
| [Fact] | ||
| public void IsRepositoryCleanWorks() |
Contributor
There was a problem hiding this comment.
issue: add test with dirty state as well
nover
force-pushed
the
57-find-a-way-to-consistently-test-the-git-vcs-provider
branch
from
4fc6c6b to
6264b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will
IVcsprovider to allow passing in a working directoryGitVcsto use passed working directoryCloses #57