Optional :entry-base-url feed property overrides base URL derivation#479
Open
kamidon wants to merge 1 commit intoskeeto:masterfrom
Open
Optional :entry-base-url feed property overrides base URL derivation#479kamidon wants to merge 1 commit intoskeeto:masterfrom
kamidon wants to merge 1 commit intoskeeto:masterfrom
Conversation
Bofore this commit, when displaying entries in 'elfeed-show-refresh--mail-style' a base URL would be inserted that was derived from the feed URL by removing any URL path and query parameters. However, some feeds are hosted on a different domain then the entries they reference. For example, the feed for kottke.org is on 'https://feeds.kottke.org/' while the entries are on just 'https://kottke.org/'. This commit allows the user to override the derived base url for entries of a feed by specify an altenative base URL in the ':entry-base-url' property on the feed. An alternative implementation that derived the base URL from the entry URL instead of the feed URL was considered but rejected because the entry URLs are controlled by the feed and following the entry URL from the elfeed UI requires a user action while the base URL for displaying embedded content in the feed data would not. With this solution the user explicitly acknowledges an additional location from which they are comfortable loading embedded content.
Author
|
Resolves issue #476. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bofore this commit, when displaying entries in
'elfeed-show-refresh--mail-style' a base URL would be inserted that was derived from the feed URL by removing any URL path and query parameters. However, some feeds are hosted on a different domain then the entries they reference. For example, the feed for kottke.org is on 'https://feeds.kottke.org/' while the entries are on just 'https://kottke.org/'.
This commit allows the user to override the derived base url for entries of a feed by specify an altenative base URL in the ':entry-base-url' property on the feed.
An alternative implementation that derived the base URL from the entry URL instead of the feed URL was considered but rejected because the entry URLs are controlled by the feed and following the entry URL from the elfeed UI requires a user action while the base URL for displaying embedded content in the feed data would not. With this solution the user explicitly acknowledges an additional location from which they are comfortable loading embedded content.