elfeed--atom-content: use 'summary' if there is no 'content'#511
Open
blbelew wants to merge 1 commit intoskeeto:masterfrom
Open
elfeed--atom-content: use 'summary' if there is no 'content'#511blbelew wants to merge 1 commit intoskeeto:masterfrom
blbelew wants to merge 1 commit intoskeeto:masterfrom
Conversation
Some atom feeds, notably GitLab's project activity feeds (project.atom) include a summary tag but no content tag. Fall back to using the summary as the content if there is no content.
|
I don't think this a good change. If there is no content it should not be shown as such but as summary. |
Author
|
The gitlab project.atom feeds show activity on any project you are subscribed to with gitlab. The way they are formatted, the "content" of the entry is entirely in the summary tag. Elfeed isn't showing that at all right now - so it doesn't display anything at all for the body of the entry. It makes sense that if if there is no content tag, but there is a summary tag, that we at least show that instead of nothing at all. |
|
I get that but putting the summary into the content tag makes it harder
to detect if there is actual content.
Further what if there's a summary and content?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some atom feeds, notably GitLab's project activity feeds (project.atom) include a summary tag but no content tag. Fall back to using the summary as the content if there is no content.