Skip to content

Normalize queue entries to avoid errors in curl queue consolidation#529

Open
czan wants to merge 1 commit intoskeeto:masterfrom
czan:master
Open

Normalize queue entries to avoid errors in curl queue consolidation#529
czan wants to merge 1 commit intoskeeto:masterfrom
czan:master

Conversation

@czan
Copy link

@czan czan commented Aug 26, 2024

This change is attempting to fix the same issue as #524, but in a slightly different way. Rather than maintaining the current shape of queue items, I've attempted to normalise the queue structure to always contain a list of URLs.

This has two advantages, to my eyes:

  1. it means the queue has a more regular structure, which makes it generally nicer to work with IMO
  2. it allows consolidation to work properly when run multiple times, rather than ignoring queue items with a list of URLs (as the code before this change did)

I believe this change will fix the issues reported in #277 (back in 2018!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant