Comply with display-buffer-alist and action#531
Open
Thaodan wants to merge 6 commits intoskeeto:masterfrom
Open
Comply with display-buffer-alist and action#531Thaodan wants to merge 6 commits intoskeeto:masterfrom
Thaodan wants to merge 6 commits intoskeeto:masterfrom
Conversation
Thaodan
added a commit
to Thaodan/emacs.d
that referenced
this pull request
Oct 14, 2024
Update csv-mode to 849ce3e Update elfeed to 3.4.2-1-gb10af59 Update llama to v0.3.1-73-ga286543 Update org to release_9.7.12-153-g90945e16a Update rpm-spec-mode to f099e01 Update yasnippet to 0.14.0-56-gfe1f4e0 Contains: skeeto/elfeed#531 Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Author
|
The last two commits refactor article rendering and should probably go into a different PR but please any feedback is welcome. |
Thaodan
force-pushed
the
respect_display_buffer
branch
4 times, most recently
from
f8a53f7 to
d43fae1
Compare
Also fix some minor errors reported by checkdoc.
By using display-buffer we can comply with display-buffer-alist or display-buffer-base-action/pop-frames.
…shr-render shr-insert-contents opens a hole new buffer and dom paser. Simply pass the S-expression to `shr-tag-a` which then only has to insert the formatted link.
Refactor entry rendering after eww. Now there's a separate render function that can specifically handle each content type. The render function is used as callback for eww if the retrieve of content through the entry link is enabled. If this is not used the render function is called directly with the content string. The retrieval of content option allows for several conditions to enable it such as always, regular expression match against the article link or length of content.
Thaodan
force-pushed
the
respect_display_buffer
branch
from
d43fae1 to
3fdc15f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using display-buffer we can comply with display-buffer-alist
or display-buffer-base-action/pop-frames.