Add more possible matches for automatic tagging#540
Open
Thaodan wants to merge 2 commits intoskeeto:masterfrom
Open
Add more possible matches for automatic tagging#540Thaodan wants to merge 2 commits intoskeeto:masterfrom
Thaodan wants to merge 2 commits intoskeeto:masterfrom
Conversation
Also fix some minor errors reported by checkdoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more possibly matches for
make-tagger.The first change is to add existing attributes from
elfeed-feedi.e.feed-author. Matching against the author is very useful for example for Youtube feeds where the url isn'tenough of a useful indicator.
The other two new matches allow matching against the enclosure or content-type.
The last change makes it possible to match against entries from the meta of feed or entry.
I think the author data should also go to the feed entry since it isn't possible to match against author for RSS feeds without it
unless matching directly against meta.