Linting improvements

[TimonVS]

• Warn for Prettier "errors" as to have eslint --fix fix formatting errors as well
• Use JSON instead of Yaml to configure ESLint. Mainly because VS Code will give autocompletion for ESLint files that are authored in JSON:

I also think we should remove eslint-plugin-import because it'll display an error when importing sketch/* modules which will confuse users.

I tried configure eslint-plugin-import in a way that it will ignore sketch/*, but you can't ignore all sketch/* modules at once, you can only do the following:

{
  "settings": {
    "import/core-modules": ["sketch", "sketch/dom", ...]
  }
}

If you agree @mathieudutour I will remove eslint-plugin-import in this PR as well.

[mathieudutour]

Warn for Prettier "errors" as to have eslint --fix fix formatting errors as well

Interesting. I personally prefer to show it at all to not be disturb while coding and just fix it on save/pre-commit. But I can be convinced otherwise. What's your workflow with eslint --fix?

Use JSON instead of Yaml to configure ESLint.

Happy to

If you agree @mathieudutour I will remove eslint-plugin-import in this PR as well.

I'd prefer to ignore the sketch modules. It's unlikely that they are going to change anyway and I really like this plugin 😄

Here is the list:

• sketch
• sketch/async
• sketch/data-supplier
• sketch/dom
• sketch/settings
• sketch/ui

[TimonVS]

Interesting. I personally prefer to show it at all to not be disturb while coding and just fix it on save/pre-commit. But I can be convinced otherwise. What's your workflow with eslint --fix?

I've configured VS Code to run auto fix on save (eslint.autoFixOnSave). I do agree with you that formatting errors can be a bit noisy. But ESLint can't auto fix a rule that doesn't emit a warning or an error :/. On the other hand, I wouldn't want users to have to download two plugins for their editor (ESLint and Prettier).

I'd prefer to ignore the sketch modules. It's unlikely that they are going to change anyway and I really like this plugin 😄

Sure :)