Akash leverj pyexchange changes20191206#104
Akash leverj pyexchange changes20191206#104mitakash wants to merge 6 commits intosky-ecosystem:masterfrom
Conversation
|
|
| Transact(self, self.web3, self.abi, self.address, self._contract, "depositEther",[app_id], {'value': int(amount.value)}).transact() | ||
| return gluon_block_number | ||
| gluon_block_number = leverjobj._http_authenticated("GET", "/api/v1", f"/plasma/{app_id}", None)['number'] + 2 | ||
| receipt = Transact(self, self.web3, self.abi, self.address, self._contract, "depositEther",[app_id], {'value': int(amount.value)}).transact() |
There was a problem hiding this comment.
do we want just to return receipt or to check here if transaction completed ok / other details?
There was a problem hiding this comment.
we need to return receipt in it's full form to be checked by inventory service with gluon block to know where we are in the processing
| Transact(self, self.web3, self.abi, self.address, self._contract, "depositToken",[app_id, token_address, amount], {}).transact() | ||
| return gluon_block_number | ||
| gluon_block_number = leverjobj._http_authenticated("GET", "/api/v1", f"/plasma/{app_id}", None)['number'] + 2 | ||
| receipt = Transact(self, self.web3, self.abi, self.address, self._contract, "depositToken",[app_id, token_address, amount], {}).transact() |
There was a problem hiding this comment.
same as above, should we just return receipt?
There was a problem hiding this comment.
We need to return both, gluon_block_number tells us where we are in the process, the hash in the receipt is eventually sent back into post_pending_tx_hash to let let leverj know we just sent something and to look for that transaction hash in pending transactions on ethereum block chain.
4 participants
No description provided.