Open
Conversation
Owner
Author
|
Для запуска нужно сначала запустить сервер, потом клиент. На клиенте открывается GUI со Swing приложением, чтобы красиво текст отображать, и управлять клавишами. Позже сбоку от самой карты будет доп инфа |
ottergottaott
requested changes
Apr 28, 2021
Collaborator
ottergottaott
left a comment
ottergottaott
left a comment
There was a problem hiding this comment.
Грязновато, исправляйте. Нужно еще добавить комментарии и хоть какие-то тесты. Пока 6 баллов
game-server/src/main/kotlin/ru/ifmo/sd/world/configuration/GameConfigurator.kt
Show resolved
Hide resolved
| import ru.ifmo.sd.world.representation.units.GameUnit | ||
|
|
||
| class EventsHandler { | ||
| companion object { |
Collaborator
There was a problem hiding this comment.
Тогда EventsHandler проще сделать object. А лучше выпилить глобальное состояние, а тут сделать нормальный класс, который держит ссылку на состояние игры (ну или что-то подобное).
Comment on lines
+3
to
+6
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| open class GameUnit(val id: Int) |
Collaborator
There was a problem hiding this comment.
Унесите это и Player в один файл, это же kotlin
game-server/src/main/kotlin/ru/ifmo/sd/world/generation/LevelGenerator.kt
Show resolved
Hide resolved
Collaborator
|
Исправления лежат в новом пул реквесте вместе с новой версией игры. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Есаков Кирилл
Сокольвяк Сергей