master-migration-6-beta#64
Open
serge-sky wants to merge 786 commits intoskytvnz:master-migration-6-betafrom
Open
master-migration-6-beta#64serge-sky wants to merge 786 commits intoskytvnz:master-migration-6-betafrom
serge-sky wants to merge 786 commits intoskytvnz:master-migration-6-betafrom
Conversation
* fix: avoid memory leak on iOS --------- Co-authored-by: Vladimir Vlasov <crivlaldo@gmail.com>
This fixes codegen not detecting library
* fix(tvOS): fix tvos compile error
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
* docs: add twg theme * docs: import theme css
* docs: add eslint * chore: remove @eslint/css * feat(docs): add custom eslint rule for css variables * ci: check lint on css changes in docs * ci: update lefthook configuration
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+48
to
+50
| videoInformation.width = Double(videoStream.width ?? Int(Double.nan)) | ||
| videoInformation.height = Double(videoStream.height ?? Int(Double.nan)) | ||
| videoInformation.bitrate = Double(videoStream.bandwidth ?? Int(Double.nan)) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
* fix: external subtitle asset composition * fix: filter for supported subtitles before adding them
packages/react-native-video/ios/core/Extensions/AVURLAsset+getAssetInformation.swift
Show resolved
Hide resolved
packages/react-native-video/ios/core/Extensions/AVURLAsset+getAssetInformation.swift
Show resolved
Hide resolved
packages/drm-plugin/ios/DRMManager/DRMManager+AVContentKeySessionDelegate.swift
Show resolved
Hide resolved
* fix(ios): prevent KVO crash in HybridVideoPlayer.release() Fix a crash that occurs when rapidly creating/destroying video players (e.g., fast swiping through a FlatList of videos). The crash message is: "Cannot remove an observer for the key path 'currentItem.status'" Root cause: When release() was called, it would set playerItem = nil and then playerObserver = nil, which triggered the observer's deinit. However, the KVO observers were still registered on the playerItem, causing a crash when the system tried to remove them. Solution: 1. Explicitly invalidate all KVO observers BEFORE changing any state 2. Change invalidatePlayerItemObservers() from private to internal so it can be called from HybridVideoPlayer.release() 3. Skip self.player.replaceCurrentItem(with: nil) which was also triggering the crash by changing currentItem while observers were still active This ensures clean KVO removal before any state changes that could interfere with the observer lifecycle. * refactor: address review feedback - clean up comments and reorganize release() - Remove verbose KVO CRASH FIX comments - Move observer invalidation calls to "Clear player observer" section - Restore replaceCurrentItem(with: nil) after observer cleanup * refactor: reorder cleaners --------- Co-authored-by: Eran Kaufman <eran@sefirot.io> Co-authored-by: Kamil Moskała <91079590+moskalakamil@users.noreply.github.com>
...ive-video/android/src/main/java/com/twg/video/core/services/playback/VideoPlaybackService.kt
Show resolved
Hide resolved
* docs: refactor tabs * docs: update video-view docs * docs: lowercase tabs * feat(docs): add downloading section * chore: add chapters example video * docs: update sidebar type * docs: update tab heading * docs: add title to fundaments * docs: lowercase plugin * docs(sidebar): remove link to offline sdk * docs: add `ads` tab * chore: add `build` to eslint ignore * docs: remove theme mermaid * refactor: update deploy values * chore: upper case tabs * refactor: update configuration tabs name * feat: add `ask for plugin` tab * refactor: update analytics tab * docs: update player class tip * docs: make chapters paid * docs: update utm's * docs(downloading): update intro * chore: bump `docusaurus-ui` package to 0.1.2 * fix: update paths * docs: update dashes * docs: update downloading events example imports * docs: update readme * docs: update case * refactor: update intro & offer
* fix: update observer thread * fix(ios): fix showNotificationControls not working when set during initialization * fix(ios): set custom metadata on AVPlayerItem for now playing info * refactor: warn when wront artwork url * docs: update file header * chore: warn when failed to load artwork image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.