Add publisherId to redirect to EQT exchange #44
Conversation
…r/Prebid.js into stx-to-eqt-exchange
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
modules/sharethroughBidAdapter.js
Outdated
| const STR_ENDPOINT = `https://btlr.sharethrough.com/universal/v1?supply_id=${SUPPLY_ID}`; | ||
| const IDENTIFIER_PREFIX = 'Sharethrough:'; | ||
|
|
||
| let impIdMap = {}; |
modules/sharethroughBidAdapter.js
Outdated
| const propertiesToConsider = [ | ||
| 'api', 'battr', 'companionad', 'companiontype', 'delivery', 'linearity', 'maxduration', 'mimes', 'minduration', 'placement', 'playbackmethod', 'plcmt', 'protocols', 'skip', 'skipafter', 'skipmin', 'startdelay' | ||
| ] | ||
| let propertiesToConsider = [ |
modules/sharethroughBidAdapter.js
Outdated
| const IDENTIFIER_PREFIX = 'Sharethrough:'; | ||
|
|
||
| let impIdMap = {}; | ||
| let isEqtTest = null; |
There was a problem hiding this comment.
Maybe we could consider to rename it into isEqtvTest to keep consistency with out custom header - X-Eqtv-Debug?
modules/sharethroughBidAdapter.js
Outdated
| topframe: inIframe() ? 0 : 1, | ||
| format: bidReq.sizes.map((size) => ({ w: +size[0], h: +size[1] })), | ||
| }; | ||
| const battr = deepAccess(bidReq, 'mediaTypes.banner.battr', null) || deepAccess(bidReq, 'ortb2Imp.banner.battr') |
There was a problem hiding this comment.
Please add semicolon also for this line
…r/Prebid.js into stx-to-eqt-exchange
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
* AGT685: Remove device info logic (#42) * AGT-680: Don't send gam in browserBlacklist (#44) * AGT-680: Dont send gam in browserBlacklist * AGT-680: fix commas * Agt 682 implementation for module (#45) * add GAM prediction * Update version number, add tests, update documentation * Fix property name * refactor export file * fix import typo * remove GAM prediction flag * extend GAM prediction documentation * fix configuration name in documentation * Agt 698 module config changes (#46) * move analytic related params to analytic adapter * Move back Maintainer section --------- Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
No description provided.