Skip to content

Fixes after review https://github.com/prebid/Prebid.js/pull/13655 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksieg-equativ merged 1 commit into from
Aug 7, 2025
Merged

Fixes after review https://github.com/prebid/Prebid.js/pull/13655 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions libraries/equativUtils/equativUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ export const PID_STORAGE_NAME = 'eqt_pid';
/**
* Handles cookie sync logic
*
* @param syncOptions
* @param serverResponses
* @param gdprConsent
* @param networkId
* @param storage
* @param {*} syncOptions A sync options object
* @param {*} serverResponses A server responses array
* @param {*} gdprConsent A gdpr consent object
* @param {number} networkId A network id
* @param {*} storage A storage object
* @returns {{type: string, url: string}[]}
*/
export function handleCookieSync(syncOptions, serverResponses, gdprConsent, networkId, storage) {
Expand Down
11 changes: 3 additions & 8 deletions modules/sharethroughBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const EQT_ENDPOINT = 'https://ssb.smartadserver.com/api/bid?callerId=233';
const STR_ENDPOINT = `https://btlr.sharethrough.com/universal/v1?supply_id=${SUPPLY_ID}`;
const IDENTIFIER_PREFIX = 'Sharethrough:';

const impIdMap = {};
let impIdMap = {};
let eqtvNetworkId = 0;
let isEqtvTest = null;

Expand Down Expand Up @@ -98,7 +98,7 @@ export const sharethroughAdapterSpec = {
test: 0,
};

req.user = nullish(firstPartyData.user, {});
req.user = firstPartyData.user ?? {}
if (!req.user.ext) req.user.ext = {};
req.user.ext.eids = bidRequests[0].userIdAsEids || [];

Expand Down Expand Up @@ -199,7 +199,7 @@ export const sharethroughAdapterSpec = {
};

impression.video = {
pos: nullish(videoRequest.pos, 0),
pos: videoRequest.pos ?? 0,
topframe: inIframe() ? 0 : 1,
w,
h,
Expand Down Expand Up @@ -376,9 +376,4 @@ function getProtocol() {
return window.location.protocol;
}

// stub for ?? operator
function nullish(input, def) {
return input === null || input === undefined ? def : input;
}

registerBidder(sharethroughAdapterSpec);
Loading