Skip to content

fix: delete-deployments behaviour#1428

Merged
erikburt merged 2 commits intomainfrom
fix/delete-deployments-ref
Feb 25, 2026
Merged

fix: delete-deployments behaviour#1428
erikburt merged 2 commits intomainfrom
fix/delete-deployments-ref

Conversation

@erikburt
Copy link
Contributor

This fixes some behavioural discrepancies I noticed with usages of the original action.

Changes

  1. Make ref optional, as no ref is used here: https://github.com/smartcontractkit/chainlink/blob/develop/.github/workflows/delete-deployments.yml
  2. Make environment required, as it's already used everywhere, and blanket deleting all deployments is probably a bad idea
  3. Don't fallback to env values for a couple inputs, we can control the usages now, so we should call it properly

DX-2999

@erikburt erikburt self-assigned this Feb 24, 2026
@erikburt erikburt marked this pull request as ready for review February 24, 2026 23:47
@erikburt erikburt requested a review from a team as a code owner February 24, 2026 23:47
@erikburt erikburt merged commit 5351309 into main Feb 25, 2026
17 checks passed
@erikburt erikburt deleted the fix/delete-deployments-ref branch February 25, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants