Skip to content

Comments

[solana] clean codec pkg#1464

Open
yashnevatia wants to merge 2 commits intodevelopfrom
clean-codec-pkg
Open

[solana] clean codec pkg#1464
yashnevatia wants to merge 2 commits intodevelopfrom
clean-codec-pkg

Conversation

@yashnevatia
Copy link
Contributor

Description

Requires Dependencies

Resolves Dependencies

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-solana

🔴 Breaking Changes (80)

package github (3)
  • com/smartcontractkit/chainlink-solana/pkg/solana/codec/testutils — 🗑️ Removed

  • com/smartcontractkit/chainlink-solana/pkg/solana/codecv2 — 🗑️ Removed

  • com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec — 🗑️ Removed

pkg/solana/codec (67)
  • AccountIDLTypes — Type changed:
  - AccountIDLTypes
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.AccountIDLTypes
)
  • CreateCodecEntry — Type changed:
func(
  interface{}, 
  string, 
  IDL, 
  github.com/smartcontractkit/chainlink-common/pkg/codec.Modifier
)
- (github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.Entry, error)
+ (Entry, error)
  • EventIDLTypes — Type changed:
  - EventIDLTypes
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.EventIDLTypes
)
  • ExtractEventIDL — Type changed:
func(
  string, 
  IDL
)
(IdlEvent, error)
  • FetchChainWriterTestIDL — 🗑️ Removed

  • FindDefinitionFromIDL — Type changed:

func(
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.ChainConfigType, 
  + ChainConfigType, 
  string, 
  IDL
)
(interface{}, error)
  • IDL — Type changed:
  - IDL
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IDL
)
  • IdlAccount — Type changed:
  - IdlAccount
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlAccount
)
  • IdlAccountItem — Type changed:
  - IdlAccountItem
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlAccountItem
)
  • IdlAccountItemSlice — Type changed:
  - IdlAccountItemSlice
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlAccountItemSlice
)
  • IdlAccounts — Type changed:
  - IdlAccounts
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlAccounts
)
  • IdlConstant — Type changed:
  - IdlConstant
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlConstant
)
  • IdlEnumFields — Type changed:
  - IdlEnumFields
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEnumFields
)
  • IdlEnumFieldsNamed — Type changed:
  - IdlEnumFieldsNamed
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEnumFieldsNamed
)
  • IdlEnumFieldsTuple — Type changed:
  - IdlEnumFieldsTuple
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEnumFieldsTuple
)
  • IdlEnumVariant — Type changed:
  - IdlEnumVariant
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEnumVariant
)
  • IdlEnumVariantSlice — Type changed:
  - IdlEnumVariantSlice
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEnumVariantSlice
)
  • IdlErrorCode — Type changed:
  - IdlErrorCode
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlErrorCode
)
  • IdlEvent — Type changed:
  - IdlEvent
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEvent
)
  • IdlEventField — Type changed:
  - IdlEventField
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEventField
)
  • IdlField — Type changed:
  - IdlField
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlField
)
  • IdlInstruction — Type changed:
  - IdlInstruction
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlInstruction
)
  • IdlType — Type changed:
  - IdlType
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlType
)
  • IdlTypeArray — Type changed:
  - IdlTypeArray
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeArray
)
  • IdlTypeAsString — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeBool — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeBytes — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeDef — Type changed:
  - IdlTypeDef
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDef
)
  • IdlTypeDefined — Type changed:
  - IdlTypeDefined
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefined
)
  • IdlTypeDefSlice — Type changed:
  - IdlTypeDefSlice
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefSlice
)
  • IdlTypeDefStruct — Type changed:
  - []IdlField
  + []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlField
)
  • IdlTypeDefTy — Type changed:
  - IdlTypeDefTy
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTy
)
  • IdlTypeDefTyEnum — Type changed:
  - IdlTypeDefTyEnum
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTyEnum
)
  • IdlTypeDefTyKind — Type changed:
  - IdlTypeDefTyKind
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTyKind
)
  • IdlTypeDefTyKindCustom — Type changed:
  - IdlTypeDefTyKind
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTyKind
)
  • IdlTypeDefTyKindEnum — Type changed:
  - IdlTypeDefTyKind
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTyKind
)
  • IdlTypeDefTyKindStruct — Type changed:
  - IdlTypeDefTyKind
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTyKind
)
  • IdlTypeDefTyStruct — Type changed:
  - IdlTypeDefTyStruct
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefTyStruct
)
  • IdlTypeDuration — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeHash — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeI128 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeI16 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeI32 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeI64 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeI8 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeOption — Type changed:
  - IdlTypeOption
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeOption
)
  • IdlTypePublicKey — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeString — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeU128 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeU16 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeU32 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeU64 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeU8 — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeUnixTimestamp — Type changed:
  - IdlTypeAsString
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeAsString
)
  • IdlTypeVec — Type changed:
  - IdlTypeVec
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeVec
)
  • InstructionArgsIDLTypes — Type changed:
  - InstructionArgsIDLTypes
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.InstructionArgsIDLTypes
)
  • NewAccountEntry — Type changed:
func(
  string, 
  AccountIDLTypes, 
  bool, 
  github.com/smartcontractkit/chainlink-common/pkg/codec.Modifier, 
  github.com/smartcontractkit/chainlink-common/pkg/codec/encodings.Builder
)
- (github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.Entry, error)
+ (Entry, error)
  • NewCodec — Type changed:
func(
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.Config
  + Config
)
(github.com/smartcontractkit/chainlink-common/pkg/types.RemoteCodec, error)
  • NewEventArgsEntry — Type changed:
func(
  string, 
  EventIDLTypes, 
  bool, 
  github.com/smartcontractkit/chainlink-common/pkg/codec.Modifier, 
  github.com/smartcontractkit/chainlink-common/pkg/codec/encodings.Builder
)
- (github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.Entry, error)
+ (Entry, error)
  • NewIDLAccountCodec — Type changed:
func(
  IDL, 
  github.com/smartcontractkit/chainlink-common/pkg/codec/encodings.Builder
)
(github.com/smartcontractkit/chainlink-common/pkg/types.RemoteCodec, error)
  • NewIDLDefinedTypesCodec — Type changed:
func(
  IDL, 
  github.com/smartcontractkit/chainlink-common/pkg/codec/encodings.Builder
)
(github.com/smartcontractkit/chainlink-common/pkg/types.RemoteCodec, error)
  • NewIdlStringType — Type changed:
func(
  IdlTypeAsString
)
IdlType
  • NewInstructionArgsEntry — Type changed:
func(
  string, 
  InstructionArgsIDLTypes, 
  github.com/smartcontractkit/chainlink-common/pkg/codec.Modifier, 
  github.com/smartcontractkit/chainlink-common/pkg/codec/encodings.Builder
)
- (github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.Entry, error)
+ (Entry, error)
  • NewPDAEntry — Type changed:
func(
  string, 
  PDATypeDef, 
  github.com/smartcontractkit/chainlink-common/pkg/codec.Modifier, 
  github.com/smartcontractkit/chainlink-common/pkg/codec/encodings.Builder
)
- (github.com/smartcontractkit/chainlink-solana/pkg/solana/commoncodec.Entry, error)
+ (Entry, error)
  • NilIdlTypeDefTy — Type changed:
  - IdlTypeDef
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDef
)
  • PDASeed — Type changed:
  - PDASeed
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.PDASeed
)
  • PDATypeDef — Type changed:
  - PDATypeDef
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.PDATypeDef
)
pkg/solana/config.ChainContractReader (7)
  • Accounts — Type changed:
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlTypeDefSlice
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefSlice
)
  • Constants — Type changed:
  - []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlConstant
  + []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlConstant
)
  • Errors — Type changed:
  - []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlErrorCode
  + []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlErrorCode
)
  • Events — Type changed:
  - []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlEvent
  + []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEvent
)
  • IDL — Type changed:
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IDL
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IDL
)
  • Instructions — Type changed:
  - []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlInstruction
  + []github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlInstruction
)
  • Types — Type changed:
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlTypeDefSlice
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefSlice
)
pkg/solana/config.ReadDefinition (1)
  • PDADefinition — Type changed:
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.PDATypeDef
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.PDATypeDef
)
pkg/solana/logpoller/types.EventIdl (2)
  • Event — Type changed:
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlEvent
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlEvent
)
  • Types — Type changed:
  - github.com/smartcontractkit/chainlink-solana/pkg/solana/codec.IdlTypeDefSlice
  + github.com/smartcontractkit/chainlink-solana/pkg/solana/codec/v1.IdlTypeDefSlice
)

📄 View full apidiff report

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
42.6% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@yashnevatia yashnevatia changed the title clean codec pkg [solana] clean codec pkg Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant