Draft
Conversation
akuzni2
reviewed
Feb 27, 2026
| streamCtxCancel context.CancelFunc | ||
| closeError atomic.Value | ||
| connStatusCallback func(isConneccted bool, host string, origin string) | ||
| connMu sync.Mutex |
Collaborator
There was a problem hiding this comment.
If we add this could we remove closingMutex?
closingMutex also guards the connection and we can likely just reuse connMu in it's place
akuzni2
reviewed
Feb 27, 2026
| cancel() | ||
| // `Add(^uint64(0))` will decrement activeConnections | ||
| s.stats.activeConnections.Add(^uint64(0)) | ||
| if s.connStatusCallback != nil { |
Collaborator
There was a problem hiding this comment.
why move this one? Its nice to have 1 call site. In the replacing changes we have 1 call that's synchronous and another one that's also async.
akuzni2
reviewed
Feb 27, 2026
| c.config.logInfo("client: failed to connect to origin %s: %s", origins[x], err) | ||
| errs = append(errs, fmt.Errorf("origin %s: %w", origins[x], err)) | ||
| // Retry connecting to the origin in the background | ||
| go func() { |
Collaborator
There was a problem hiding this comment.
should we also make this use named parameters?
go func(s *stream, origin string)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.