Conversation
🦋 Changeset detectedLatest commit: 281211d The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e7ddc5f to
517f8b9
Compare
|
How do you plan to release all these? |
|
In the framework PR, we should also update the EA generator to include |
2e8797c to
e6fb8e0
Compare
|
@mxiao-cll In an ideal world, these changes just ship when other new changes to an EA go out. Do you have a recommendation for how to do that? |
In this case, do not create a changeset |
|
It is ok to not create a changeset because there is no material change here |
|
I think you won't be allowed to merge when changing source files without changeset. And I don't see the problem with having a patch changeset for these. But putting all or many EAs in the same changeset file will make it impossible to release any of these EAs individually. So ideally there will be a separate changset file per EA. And to be honest, I think it would even be cleaner to have a separate PR per EA. That way each one can be reviewed individually and get the attention it deserves. And can be easily reverted individually if needed. I'd be happy to split the PR into separate small PRs if you don't have time for that. |
e6fb8e0 to
0c2b1a8
Compare
0c2b1a8 to
281211d
Compare
|
You have a build error: I think this happens because @mxiao-cll added Meanwhile, I recommend that you split the PR by starting with a single EA that does not have problems to see that it works. |
|
Yes, I think we need to re-factor |
Description
Explicitly flag configs as insensitive where appropriate. This is in preparation for configs to default to sensitive: true and explicitly opt in to revealing in logs etc.
In preparation for this change: smartcontractkit/ea-framework-js#660
Will update framework for all EAs in a follow up PR
......
Changes
Steps to Test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.