DOCS : Readme updated for better understanding of how to accept ownership#198
Open
virajpatva wants to merge 3 commits intosmartcontractkit:mainfrom
Open
DOCS : Readme updated for better understanding of how to accept ownership#198virajpatva wants to merge 3 commits intosmartcontractkit:mainfrom
virajpatva wants to merge 3 commits intosmartcontractkit:mainfrom
Conversation
Contributor
Author
|
@KuphJr @zeuslawyer please review , I am unable to add reviewer |
zeuslawyer
reviewed
Dec 15, 2023
zeuslawyer
requested changes
Dec 15, 2023
Collaborator
zeuslawyer
left a comment
zeuslawyer
left a comment
There was a problem hiding this comment.
@virajpatva one nit please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject: README Enhancements for Issue #194 - functions-hardhat-starter-kit
Hi Team,
I've implemented improvements in the README to address the concerns raised in Issue #194. Your feedback on the changes is greatly appreciated.
Summary of Updates:
Enhanced Importance of SECOND_PRIVATE_KEY:
Added Requisite Message for 'functions-sub-accept':
Please take a moment to review these modifications and let me know if any further clarification or adjustments are required.
Best regards,
Viraj Patva