forked from synmetrix/synmetrix
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature: Automatic Docker container builds with GitHub Actions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create unified workflow for all 7 custom containers - Implement path-based change detection for selective builds - Add manual workflow dispatch for specific service builds - Disable legacy workflow to prevent conflicts - Support both quicklookup/ and synmetrix/ registries
- Update all @cubejs-backend packages from 1.3.23 to 1.3.85 using npm update - Includes latest features, performance improvements, and bug fixes - All packages tested and working correctly
- Add comprehensive build summary job that runs after all builds - Display built images, their tags, and push status in GitHub Actions UI - Show build success/failure status for each service - Include commit SHA, branch tags, and latest tag information - Use GitHub Step Summary for rich markdown formatting
- Document recent v1.3.85 upgrade process and changes - Include architecture overview and configuration details - Add development, Docker, and Kubernetes deployment info - Note security considerations and next steps
Focus only on actual work performed - CubeJS package upgrade process
Mention that pushing will trigger selective build of cubejs container
- Replace duplicated git diff checks with loop-based change detection - Add per-service Docker cache scoping to prevent cache conflicts - Fix boolean input handling for workflow_dispatch - Use shell parameter expansion instead of sed for comma removal - Improve shell scripting best practices and maintainability
Add .buildinfo files to all service directories to test selective build workflow: - services/actions/ → quicklookup/synmetrix-actions - services/cubejs/ → quicklookup/synmetrix-cube (already changed) - services/client/ → quicklookup/synmetrix-client - services/hasura/ → quicklookup/synmetrix-hasura - scripts/containers/hasura-backend-plus/ → quicklookup/hasura-backend-plus - scripts/containers/stack/ → synmetrix/stack - scripts/containers/stepci/ → quicklookup/synmetrix-stepci This will trigger builds for all 7 custom containers when pushed.
- Remove synmetrix/stack from workflow (was causing build failures) - Fix build summary to handle matrix job partial failures correctly - Show⚠️ Mixed status when some services fail but others succeed - Add documentation about stack container removal - Reduce supported services from 7 to 6
Trigger builds for all 6 remaining services: - actions: quicklookup/synmetrix-actions - cubejs: quicklookup/synmetrix-cube (with v1.3.85 upgrade) - client: quicklookup/synmetrix-client - hasura-cli: quicklookup/synmetrix-hasura - hasura-backend-plus: quicklookup/hasura-backend-plus - stepci: quicklookup/synmetrix-stepci Stack container removed due to build failures. Build summary now handles partial failures correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements automated selective Docker container builds using GitHub Actions, replacing the previous manual build process.
Changes
{branch}-{short-sha}format for easier deployment trackingSupported Services
quicklookup/synmetrix-actions(Node.js backend)quicklookup/synmetrix-cube(CubeJS analytics)quicklookup/synmetrix-client(React frontend)quicklookup/synmetrix-hasura(GraphQL API)quicklookup/hasura-backend-plus(Auth backend)Updated Documentation
RELEASING.mdwith automated build process and deployment instructionsTest Plan