Script update for 1880 issue#2670
Open
GetmanetsIrina wants to merge 2 commits intosmartdevicelink:developfrom
Open
Script update for 1880 issue#2670GetmanetsIrina wants to merge 2 commits intosmartdevicelink:developfrom
GetmanetsIrina wants to merge 2 commits intosmartdevicelink:developfrom
Conversation
Contributor
Author
|
PR is related to #2000 |
Contributor
Author
|
The issue smartdevicelink/sdl_core#3914 has been created according to result of scripts execution |
Contributor
Author
|
@theresalech, this PR is ready for Livio review. |
ShobhitAd
requested changes
Jun 8, 2022
| m.sendUIresp = true | ||
| m.sendVRresp = true | ||
| m.notSendUIresp = false | ||
| m.notSsendVRresp = false |
Contributor
There was a problem hiding this comment.
Suggested change
| m.notSsendVRresp = false | |
| m.notSendVRresp = false |
to keep it consistent with the notSendUIresp constant.
| -- - start timeout <DefaultTimeout> + <*RPCs_own_timeout> for expecting VR response | ||
| -- 5. HMI does not respond to UI and VR requests during <DefaultTimeout> + <*RPCs_own_timeout> | ||
| -- SDL does: | ||
| -- - respond 'GENERIC_ERROR, success:false' to mobile app after <DefaultTimeout> + <*RPCs_own_timeout> is expired |
Contributor
There was a problem hiding this comment.
This expectation is failing since core is not sending a GENERIC_ERROR response within that specified timeout.
[09:49:14,866] PerformInteraction_default_timeout_and_PI_timeout [FAIL] (21588 ms)
Response to 4: Timeout: Response to 4: Timeout expired
Looking at the core logs, this seems to be due to UpdateRequestTimeout being called in PerformInteractionRequest::OnTimeOut() for the BOTH interactionMode.
sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/perform_interaction_request.cc:308 commands::PerformInteractionRequest::OnTimeOut: Enter
sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/perform_interaction_request.cc:312 commands::PerformInteractionRequest::OnTimeOut: Interaction Mode: BOTH
sdl_core/src/components/application_manager/src/application_manager_impl.cc:3035 ApplicationManagerImpl::UpdateRequestTimeout: Enter
sdl_core/src/components/application_manager/src/request_controller_impl.cc:464 request_controller::RequestControllerImpl::UpdateRequestTimeout: Enter
sdl_core/src/components/application_manager/src/request_controller_impl.cc:465 request_controller::RequestControllerImpl::UpdateRequestTimeout: app_id : 65537 mobile_correlation_id : 4 new_timeout : 25000
sdl_core/src/components/application_manager/src/commands/command_request_impl.cc:180 commands::CommandRequestImpl::OnUpdateTimeOut: Enter
sdl_core/src/components/application_manager/src/commands/command_request_impl.cc:180 commands::CommandRequestImpl::OnUpdateTimeOut: Exit
sdl_core/src/components/application_manager/src/request_controller_impl.cc:702 request_controller::RequestControllerImpl::NotifyTimer: Enter
sdl_core/src/components/application_manager/src/request_controller_impl.cc:702 request_controller::RequestControllerImpl::NotifyTimer: Exit
sdl_core/src/components/application_manager/src/request_controller_impl.cc:489 request_controller::RequestControllerImpl::UpdateRequestTimeout: Timeout updated for app_id: 65537 correlation_id: 4 new_timeout (ms): 25000
sdl_core/src/components/application_manager/src/request_controller_impl.cc:464 request_controller::RequestControllerImpl::UpdateRequestTimeout: Exit
sdl_core/src/components/application_manager/src/application_manager_impl.cc:3035 ApplicationManagerImpl::UpdateRequestTimeout: Exit
sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/perform_interaction_request.cc:308 commands::PerformInteractionRequest::OnTimeOut: Exit
Contributor
Author
There was a problem hiding this comment.
The issue smartdevicelink/sdl_core#3914 has been created according to scripts result.
This issue collects issues with timeouts for PerformInteraction, so maybe a merge of this issue should be related to the fix of smartdevicelink/sdl_core#3914
Contributor
There was a problem hiding this comment.
I see, in that case I think #3914 should be added to the PR title and/or description
Contributor
Author
There was a problem hiding this comment.
Added 3914 to the description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check #1880 and #3914
This PR is ready for review.
Summary
Script update for 1880 issue and coverage for 3914
ATF version
develop
Changelog
CLA