Add test scripts for 2451 issue#2691
Add test scripts for 2451 issue#2691GetmanetsIrina wants to merge 2 commits intosmartdevicelink:developfrom
Conversation
GetmanetsIrina
changed the title
|
Test results have triggered creation of smartdevicelink/sdl_core#3935 and smartdevicelink/sdl_core#3934 |
|
@theresalech, this PR is ready for Livio review. |
| "0x95,0x96,0x97,0x98,0x99,0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0x9A" | ||
|
|
||
| local tcs = { | ||
| [01] = { name = "min value", value = "0x01, 0x00" }, |
There was a problem hiding this comment.
This test case fails at the moment. I'm assuming due to smartdevicelink/sdl_core#3935. Please add a note in the description stating the test is blocked until the core issue is fixed
| "0x95,0x96,0x97,0x98,0x99,0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0x9A" | ||
|
|
||
| local tcs = { | ||
| [01] = { name = "out of min size", value = "" }, |
There was a problem hiding this comment.
| [01] = { name = "out of min size", value = "" }, | |
| [01] = { name = "out of min size", value = "", expected = nil }, |
The undefined value should already be nil but it just seems strange to pass an undefined variable to the appRegistration function
|
|
||
| local tcs = { | ||
| [01] = { name = "out of min size", value = "" }, | ||
| [02] = { name = "out of max size", value = maxValue .. ",0x9B", expected = maxValue } |
There was a problem hiding this comment.
This test case fails at the moment. I'm assuming due to smartdevicelink/sdl_core#3934. Please add a note in the description stating the test is blocked until the core issue is fixed
|
@ShobhitAd, all comments have been addressed in 4ee9222 |
2 participants
ATF Test Scripts to check #2451 and new created #3935, #3934
This PR is ready for review.
Summary
Scripts to check 2451 issue
ATF version
latest
Changelog
CLA