Add missed setup of last_processed_event_#1616
Open
LitvinenkoIra wants to merge 1 commit intosmartdevicelink:developfrom
Open
Add missed setup of last_processed_event_#1616LitvinenkoIra wants to merge 1 commit intosmartdevicelink:developfrom
LitvinenkoIra wants to merge 1 commit intosmartdevicelink:developfrom
Conversation
Add missed last_processed_event_ key setup from changes related to "Fix UPDATE_NEEDED is sent if user requested PTU from HMI".
Contributor
Author
|
@LuxoftAKutsan @dev-gh @AByzhynar @AKalinich-Luxoft please review |
AByzhynar
approved these changes
Jun 16, 2017
Contributor
|
@LitvinenkoIra
Currently you just describe obvious things seen from code difference but w/o any understanding what for and why. |
LuxoftAKutsan
approved these changes
Jun 19, 2017
Contributor
|
@LitvinenkoIra please specify more clearly what was the defect and root cause. |
Contributor
Author
|
@dev-gh @LuxoftAKutsan updated description |
dev-gh
approved these changes
Jun 19, 2017
AKalinich-Luxoft
approved these changes
Jun 19, 2017
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main problem that it is the only one case when we should not send notification about update needed on HMI.
And in this PR I add missed last_processed_event_ key setup from changes related to "Fix UPDATE_NEEDED is sent if user requested PTU from HMI". #1491