Skip to content

solution: day 2 - task 1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smartlime wants to merge 1 commit into
base: day-2
Choose a base branch
from
Open

solution: day 2 - task 1 #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/views/layouts/_flash.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,20 @@
<div class="fixed z-50 right-0 mr-4 top-0 mt-[80px]" id="flash">
<div class="flex justify-center">
<% if flash[:notice] %>
<div class="flash notice" role="alert" data-turbo-temporary data-controller="removeable" data-removeable-after-value="5">
<div class="flash notice" role="alert" data-turbo-temporary data-controller="removeable" data-removeable-after-value="10">
<p class="text-small"><%= flash[:notice] %></p>
<button class="absolute top-0 bottom-0 right-0 px-2 py-3" data-action="click->removeable#remove">
<svg class="fill-current h-6 w-6 hover:text-primary" role="button" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"><title>Close</title><path d="M14.348 14.849a1.2 1.2 0 0 1-1.697 0L10 11.819l-2.651 3.029a1.2 1.2 0 1 1-1.697-1.697l2.758-3.15-2.759-3.152a1.2 1.2 0 1 1 1.697-1.697L10 8.183l2.651-3.031a1.2 1.2 0 1 1 1.697 1.697l-2.758 3.152 2.758 3.15a1.2 1.2 0 0 1 0 1.698z"/></svg>
Copy link

@palkan palkan Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Иконку, конечно, лучше положить в views/icons, как это сделано везде

Copy link
Owner Author

@smartlime smartlime Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да) Я это отразил только на 3-м дне, кажется.

</button>
</div>
<% end %>

<% if flash[:alert] %>
<div class="flash alert" role="alert" data-turbo-temporary data-controller="removeable" data-removeable-after-value="5">
<p class="text-small"><%= flash[:alert] %></p>
<button class="absolute top-0 bottom-0 right-0 px-2 py-3" data-action="click->removeable#remove">
<svg class="fill-current h-6 w-6 hover:text-primary" role="button" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"><title>Close</title><path d="M14.348 14.849a1.2 1.2 0 0 1-1.697 0L10 11.819l-2.651 3.029a1.2 1.2 0 1 1-1.697-1.697l2.758-3.15-2.759-3.152a1.2 1.2 0 1 1 1.697-1.697L10 8.183l2.651-3.031a1.2 1.2 0 1 1 1.697 1.697l-2.758 3.152 2.758 3.15a1.2 1.2 0 0 1 0 1.698z"/></svg>
</button>
</div>
<% end %>
</div>
Expand Down