Skip to content

solution: day 2 - task 3 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smartlime wants to merge 1 commit into
base: day-2
Choose a base branch
from
Open

solution: day 2 - task 3 #5

smartlime wants to merge 1 commit into from

Conversation

@smartlime
Copy link
Owner

@smartlime smartlime commented Jul 30, 2023

No description provided.

palkan
palkan approved these changes Aug 3, 2023
View reviewed changes
Copy link

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app/javascript/controllers/player_controller.js
this.playing = false;

useHotkeys(this, {
'space': [this.toggle],
Copy link

@palkan palkan Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть подозрение, что без отдельного обработчика события не обойтись, так как нам нужно блокировать поведение браузера по умолчанию (а это прокрутка), то есть, preventDefault().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@palkan palkan palkan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartlime @palkan