Fix compileAll() behavior. #1157
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compileAll() has two issues that get fixed with this commit: 1. `$force_compile` is ignored since it is applied to a cloned instance of Smarty that then is not used. 2. The `$max_errors` variable behaves strange as the function stops executing as soon $max_errors is reached. However, the name suggests that `$max_errors` is the maximum number of acceptable errors (defaults to `null` meaning unlimited). When called with `$max_errors = 0`, the function compiles only the first template and then stops with "too many errors" and a total error count of zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compileAll()has two issues that get fixed with this commit:$force_compileis ignored since it is applied to a cloned instance of Smarty that then is not used.$max_errorsvariable behaves strange as the function stops executing as soon $max_errors is reached. However, the name suggests that$max_errorsis the maximum number of acceptable errors (defaults tonullmeaning unlimited). When called with$max_errors = 0, the function compiles only the first template and then stops with "too many errors" and a total error count of zero.