Fix {strip} block removing spaces between HTML attributes. #1161
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{strip} removed spaces between HTML attributes in some cases like e.g.,
`<a href=\"{'genLink'}\"\n target=\"_blank\">`. This is due to the Smarty tag in the middle splitting the text block up and so the regex does not recognize the HTML attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
{strip} removed spaces between HTML attributes in some cases like e.g.,
<a href=\"{'genLink'}\"\n target=\"_blank\">. This is due to the Smarty tag in the middle splitting the text block up and so the regex does not recognize the HTML attribute.Changes
This PR adds a regex to look for a
"(the end of an attribute) followed by something that looks like another attribute[a-z-]+=". In this case the space in the middle is replaced by a single space instead of being completely removed. The PR also adds two tests for this case which resemble the circumstances under which I encountered this bug.