Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces gunit/v2, a major revision of the testing framework with improved design and error handling. The v2 implementation is isolated in a /v2 subdirectory to maintain backward compatibility with v1 code, allowing existing projects to continue using v1 while new projects can adopt v2 from the start.
Key changes:
- Enhanced test runner that supports both unit tests (parallel execution with fresh fixtures) and integration tests (shared fixtures)
- Assertions now return actual error values instead of just failing tests, enabling better error handling patterns
- Comprehensive assertion library with clear error reporting and stack traces
Reviewed changes
Copilot reviewed 94 out of 94 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| v2/go.mod | Defines the v2 module requiring Go 1.25 |
| v2/gunit.go | Core test runner with fixture lifecycle management |
| v2/options.go | Configuration options for test execution modes |
| v2/fixture.go | Base fixture type with assertion helpers |
| v2/assert/should/*.go | Assertion library with various comparison functions |
| v2/examples/bowling_game*.go | Example bowling game implementation and tests |
| v2/assert/should/internal/ | Third-party libraries for diff/render functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once thought to be merely a mythical creature,
gunit/v2is here, more real than ever.NOTE: The
v2module has been defined in its very own/v2subdirectory so that thev1code can remain here with continuing support. There's no need to portv1test fixtures tov2(nor am I recommending that) but new projects should usev2from the start.