fix: LS26000366: no error when adding formula column#2814
Merged
pasere-smeup merged 1 commit intodevelopfrom Mar 2, 2026
Merged
fix: LS26000366: no error when adding formula column#2814pasere-smeup merged 1 commit intodevelopfrom
pasere-smeup merged 1 commit intodevelopfrom
Conversation
zammarchi-smeup
requested review from
Leonardo-Signorelli,
lucafoscili and
pasere-smeup
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how new columns, especially those resulting from mathematical operations, are handled and displayed in the data table component. The main focus is on ensuring that newly added columns are always visible and that their metadata is correctly initialized, even when optional values are missing.
This solves an issue where adding 2 columns with the same formula generated errors
Enhancements to new column handling:
objproperty in new columns is always initialized, defaulting to an empty object structure if not provided.visibleproperty totruefor new columns created from mathematical operations, guaranteeing they appear by default.Improvements to visible column management:
KupDataTableto better handle the insertion and display of new columns, especially when determining which columns should be visible after a new column is added. This prevents duplicate columns and ensures correct updates to thevisibleColumnsarray.