Skip to content

fix: LS26000636: renamed button search into preview #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasere-smeup merged 1 commit into from
Mar 2, 2026
Merged

fix: LS26000636: renamed button search into preview #2815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/ketchup/src/components/kup-card/dialog/kup-card-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export function create8(component: KupCard): VNode {
const isReservedID = (id: string) => {
return (
id === KupColumnMenuIds.BUTTON_OPEN_IN_NEW ||
id === KupColumnMenuIds.BUTTON_SEARCH ||
id === KupColumnMenuIds.BUTTON_PREVIEW ||
id === KupColumnMenuIds.BUTTON_COPY_OBJ
);
};
Expand Down Expand Up @@ -377,7 +377,7 @@ export function create8(component: KupCard): VNode {
<div class="sub-1">
{textArray[0] ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_OPEN_IN_NEW) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_SEARCH) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_PREVIEW) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_COPY_OBJ) ? (
<div class="top">
{textArray[0] ? (
Expand All @@ -394,7 +394,7 @@ export function create8(component: KupCard): VNode {
KupColumnMenuIds.BUTTON_OPEN_IN_NEW
) ||
buttonsIds.includes(
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
) ||
buttonsIds.includes(
KupColumnMenuIds.BUTTON_COPY_OBJ
Expand All @@ -412,13 +412,13 @@ export function create8(component: KupCard): VNode {
/>
) : null}
{buttonsIds.includes(
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
) ? (
<kup-button
{...buttonArray.find(
(x) =>
x.id ===
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
)}
/>
) : null}
Expand Down
18 changes: 9 additions & 9 deletions packages/ketchup/src/components/kup-card/standard/kup-card-standard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ export function create14(component: KupCard): VNode {
buttonsIds.includes(
KupColumnMenuIds.BUTTON_OPEN_IN_NEW
) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_SEARCH) ? (
buttonsIds.includes(KupColumnMenuIds.BUTTON_PREVIEW) ? (
<div class="top">
{textArray[0] ? (
<div class="title">
Expand All @@ -1110,7 +1110,7 @@ export function create14(component: KupCard): VNode {
KupColumnMenuIds.BUTTON_OPEN_IN_NEW
) ||
buttonsIds.includes(
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
) ? (
<div class="buttons">
{buttonsIds.includes(
Expand All @@ -1125,13 +1125,13 @@ export function create14(component: KupCard): VNode {
/>
) : null}
{buttonsIds.includes(
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
) ? (
<kup-button
{...buttonArray.find(
(x) =>
x.id ===
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
)}
/>
) : null}
Expand Down Expand Up @@ -1432,7 +1432,7 @@ export function create15(component: KupCard): VNode {
const isReservedID = (id: string) => {
return (
id === KupColumnMenuIds.BUTTON_OPEN_IN_NEW ||
id === KupColumnMenuIds.BUTTON_SEARCH ||
id === KupColumnMenuIds.BUTTON_PREVIEW ||
id === KupColumnMenuIds.BUTTON_COPY_OBJ
);
};
Expand Down Expand Up @@ -1491,7 +1491,7 @@ export function create15(component: KupCard): VNode {
<div class="sub-1">
{textArray[0] ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_OPEN_IN_NEW) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_SEARCH) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_PREVIEW) ||
buttonsIds.includes(KupColumnMenuIds.BUTTON_COPY_OBJ) ? (
<div class="top">
{textArray[0] ? (
Expand All @@ -1508,7 +1508,7 @@ export function create15(component: KupCard): VNode {
KupColumnMenuIds.BUTTON_OPEN_IN_NEW
) ||
buttonsIds.includes(
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
) ||
buttonsIds.includes(
KupColumnMenuIds.BUTTON_COPY_OBJ
Expand All @@ -1526,13 +1526,13 @@ export function create15(component: KupCard): VNode {
/>
) : null}
{buttonsIds.includes(
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
) ? (
<kup-button
{...buttonArray.find(
(x) =>
x.id ===
KupColumnMenuIds.BUTTON_SEARCH
KupColumnMenuIds.BUTTON_PREVIEW
)}
/>
) : null}
Expand Down
2 changes: 1 addition & 1 deletion packages/ketchup/src/utils/kup-column-menu/kup-column-menu-declarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export enum KupColumnMenuIds {
BUTTON_NEW = 'new',
BUTTON_OPEN_IN_NEW = 'open-in-new',
BUTTON_REMOVE = 'remove',
BUTTON_SEARCH = 'search',
BUTTON_PREVIEW = 'preview',
BUTTON_COPY_OBJ = 'copy-obj',
CHECKBOX_GLOBAL = 'global-checkbox',
SWITCH_GROUP = 'group',
Expand Down