fix: Use column size for Kup images; restrict icon removal#2816
Merged
pasere-smeup merged 1 commit intodevelopfrom Mar 3, 2026
Merged
fix: Use column size for Kup images; restrict icon removal#2816pasere-smeup merged 1 commit intodevelopfrom
pasere-smeup merged 1 commit intodevelopfrom
Conversation
Pass the column into setCellSizeKup so image cells can inherit column.size for sizeX when sizeX is not provided. Also tighten the mouseleave selector to only remove the action icon (kup-image.f-cell__iconfunction) instead of the first kup-image in the cell, preventing accidental removal of the main BAR/IMAGE element.
lucafoscili
requested review from
Leonardo-Signorelli and
pasere-smeup
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the column into setCellSizeKup so image cells can inherit column.size for sizeX when sizeX is not provided. Also tighten the mouseleave selector to only remove the action icon (kup-image.f-cell__iconfunction) instead of the first kup-image in the cell, preventing accidental removal of the main BAR/IMAGE element.