Don't add from __future__ import print_function in generated file#3
Open
santazhang wants to merge 2 commits intosmurfix:masterfrom
Open
Don't add from __future__ import print_function in generated file#3santazhang wants to merge 2 commits intosmurfix:masterfrom
from __future__ import print_function in generated file#3santazhang wants to merge 2 commits intosmurfix:masterfrom
Conversation
`from __future__ import print_function` must be placed at beginning of python file. But the user might have a header code section specified in .g file (before %% marker), and in this case the generated parser will not work. I think it's better to let users add `from __future__ import print_function` themselves.
Users might or might not add `from __future__ import print_function`. Generated code should work in either case.
|
I just ran into the same issue, and worked around it by editing the generated parser. The simpler solution is to insert the pre-parse code from the grammar file after the import statements, rather than before. Nothing else needs to be changed. |
|
#6 resolves this in a way that still allows the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from __future__ import print_functionmust be placed at beginning of python file. But the user might have a header code section specified in .g file (before %% marker), and in this case the generated parser will not work. I think it's better to let users addfrom __future__ import print_functionthemselves.