Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
============================================
- Coverage 86.59% 85.75% -0.85%
+ Complexity 124 122 -2
============================================
Files 25 26 +1
Lines 1492 1558 +66
Branches 36 36
============================================
+ Hits 1292 1336 +44
- Misses 184 203 +19
- Partials 16 19 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sne11ius
force-pushed
the
delay_user_leave_during_showcards
branch
2 times, most recently
from
dd72ef9 to
4d48327
Compare
sne11ius
force-pushed
the
delay_user_leave_during_showcards
branch
from
4d48327 to
f59a460
Compare
Previously, the client just panicked - and by not shutting down the tui normally, left the console in shambles.
For example, there's nothing to reveal, if the cards are already revealed.
In the past, if a user left (or joined) while the cards were revealed, the average would change since it was always computed from the "current" users. Now, the client will show data from "gameResult" room property which is computed the exact moment the cards are revealed and will not change even if users join or leave
sne11ius
force-pushed
the
delay_user_leave_during_showcards
branch
from
0cdba34 to
85c48fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.