Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change no longer supports older TYPO3 versions. It is possibly advisable to branch current master to support versions 8 and below separately or merge this into another branch.
I made changes based on what the core Extension Scanner showed. Basic tests work (extension installation), setting up an "IP-Authentication configuration", assigning an FE User and testing if a page displayed for IP address range.
What did not work was selecting an FE group in the configuration record, only FE user. I don't know if that is related to my changes, I might test on TYPO3 8 with current master.
Only did basic tests so far.