[Linked List] Add a solution to Convert Sorted List to Binary Search …#270
Open
LucasXu0 wants to merge 1 commit intosoapyigu:masterfrom
Open
[Linked List] Add a solution to Convert Sorted List to Binary Search …#270LucasXu0 wants to merge 1 commit intosoapyigu:masterfrom
LucasXu0 wants to merge 1 commit intosoapyigu:masterfrom
Conversation
Author
|
please check this PR. |
alexxie16
approved these changes
Nov 4, 2019
| while cur != nil { | ||
| sortedArr.append(cur!.val) | ||
| cur = cur!.next | ||
| } |
Contributor
There was a problem hiding this comment.
Do you think you can do something like this below, so you don't have to implicitly unwrap the variable which is not recommended in production code?
while let newCurr = cur {
sortedArr.append(newCurr.val)
cur = newCurr.next
}
| private func _helper(_ sortedArr: [Int], _ left: Int, _ right: Int) -> TreeNode? { | ||
| guard left <= right else { return nil } | ||
|
|
||
| let mid = left + (right - left) >> 1 |
Contributor
There was a problem hiding this comment.
the >> operation is so cool! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a solution to Convert Sorted List to Binary Search Tree