NUI 6263 search component accessibility

[ludmilaFialova]

https://swicloud.atlassian.net/browse/NUI-6263

ER:

The Search button opens a pop-up when the Spacebar key is pressed.
The expanded search bar closes when the Esc key is pressed.
The buttons have sufficient contrast when focused.

The cancel button next to the Search bar is focusable by the Tab key and is called “Clear search button”

The magnifier icon next to the Search bar is hidden for the screen reader.

The buttons in the “Recent searches” area are accessible by the Tab key. I can get to the search by pressing the Enter or Space bar key. The caret-right icon is hidden.

When returning to some text in the search field, I hear: “Search edit selected all”

https://swicloud.atlassian.net/browse/OO-55517

ER:

The icon will be hidden for the SR. There will be no error in AXE DevTool.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have updated change log
• I have been following Definition of done
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new lint warnings
• New and existing unit tests pass locally and on CI with my changes
• Any dependent changes have been merged and published in downstream modules

[pavlo-poimanov]

will it cause the possible regression? visually it looks the same? I bet the e2e, ui tests may be broken

[ludmilaFialova]

Visually, it is ok
If you mean tests in CircleCI, they passed...

[pavlo-poimanov]

image/popup/repeat should be fine but the search I'm not sure this changes will not cause problems. double check if all fine then ok.

also you can be a good camper and do next:

• make this true standalone components
• rewrite to signals control flow
• ngDestory => destroyRef
• inject() function

first camp fire rule - leave place better than it was before you ;)

[pavlo-poimanov]

I do think this caused the regression on the menu.
On the keydown enter it had to do ckeckbox checking. See the test.

[pavlo-poimanov]

in test it waits the menu still be opened